-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
zellij/0.41.2-r1: cve remediation #35025
Conversation
Gen AI suggestions to solve the build error: • Detected Error:
• Error Category: Dependency/Version • Failure Point: rust/cargobump step when attempting to update the wasmtime dependency • Root Cause Analysis: The cargobump tool is trying to update wasmtime to a newer version, but zellij-server specifically requires wasmtime 21.0.2, while only version 24.0.2 is available in the crates.io index. • Suggested Fix: exclude:
- wasmtime • Explanation: • Additional Notes:
• References:
|
Gen AI suggestions to solve the build error: • Detected Error:
• Error Category: Dependency Version Conflict • Failure Point: rust/cargobump step during dependency update • Root Cause Analysis: The package requires wasmtime v21.0.2, but this version is no longer available in crates.io. The only available version is 25.0.0, which is incompatible with the current package version. • Suggested Fix:
dependencies:
- name: wasmtime
version: "25.0.0"
- uses: rust/cargobump
with:
packages:
- [email protected] • Explanation: The wasmtime dependency has undergone a major version update from 21.x to 25.x. Since this is a breaking change, we need to explicitly specify the version compatibility. The fix will allow the build system to use the newer version of wasmtime. • Additional Notes:
• References: |
Signed-off-by: Hector Fernandez <[email protected]>
810359e
to
6afd537
Compare
Gen AI suggestions to solve the build error: Based on the build error log, I'll help analyze and resolve the issue: • Detected Error: "2024/12/30 14:56:40 INFO Update package: cap-primitives" (followed by build failure) • Error Category: Dependency • Failure Point: During the • Root Cause Analysis: The cargobump tool is detecting outdated dependencies but appears to be failing silently. The error occurs during dependency version bumping, likely due to incompatible version constraints or missing cargobump configuration. • Suggested Fix:
# cargobump-deps.yaml
dependencies:
- name: cap-primitives
version: "=1.0.1" # Use explicit version
pipeline:
- uses: git-checkout
with:
repository: https://github.com/zellij-org/zellij
tag: v${{package.version}}
expected-commit: 40d49737d126eef60dd988f1fe60df4c42d23773
# Remove or comment out the cargobump step
# - uses: rust/cargobump • Explanation: The cargobump tool is trying to update Rust dependencies but failing. Since we're building a specific tagged version (v0.41.2), we should either properly configure cargobump or skip it entirely to maintain the exact dependencies specified in the original Cargo.lock file. • Additional Notes:
• References:
|
Signed-off-by: Mark McCormick <[email protected]>
The vuln looks to affect windows, so this may turn out to be an advisory vs a requirement to bump. I did file this with the upstream maintainers, who also noted that while they leverage wasmtime, zellij itself doesn't support windows: |
Advisory raised: |
closing, advisory raised: |
Remediates: GHSA-c2f5-jxjv-2hh8. The other two findings in the CI CVE scan are not related to this CVE fix.
zellij/0.41.2-r1: fix GHSA-c2f5-jxjv-2hh8
Advisory data: https://github.com/wolfi-dev/advisories/blob/main/zellij.advisories.yaml